[freqtbl-] Default disp_histogram to U+25A0 BLACK SQUARE (■) #1949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here:
#1807 (reply in thread)
Copying my comment from the discussion above below:
So there I was, innocently reading through the Notcurses book, when I encountered the following paragraph in section 7.6 Stupid Unicode Tricks:
I was already thinking of the visidata histogram, and when I read the words "middle half block", I had to try it.
Here is the result:
Before:
After:
It's not perfect, because the block is not quite in the vertical middle, and there's a small gap between each character.
But I think it's pretty close to the best we can get for default visidata, because there's vertical space both above and below which avoids problems with the reverse video line highlight.
And it's a solid improvement over
*
.@saulpw, would you consider making this the default character for
options.disp_histogram
?(Bonus points if we can squeeze it into 2.11.1!)